Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the migration tool, it's confusing that added hints don't turn red until after the migration is re-run. #44311

Closed
stereotype441 opened this issue Nov 24, 2020 · 1 comment
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P3 A lower priority bug or feature request

Comments

@stereotype441
Copy link
Member

stereotype441 commented Nov 24, 2020

The migration tool uses red highlighting to show text it's going to remove. This means that a hint such as /*!*/ applied to a type will be completely red, and a hint such as /*?*/ applied to a type will be completely red except for the ?.

When you click on an add /*!*/ hint or add /*?*/ hint button in the migration tool UI, it isn't immediately highlighted in red; it's not highlighted until you re-run migration from sources.

This is potentially confusing for users, because they may see the hint become red at a later time and wonder why.

This arose in the discussion around #44280.

@stereotype441 stereotype441 added P3 A lower priority bug or feature request area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). labels Nov 24, 2020
@stereotype441
Copy link
Member Author

As of 1c7fe71, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.

If you still need help, or you believe this issue has been closed in error, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

1 participant