Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDS] support requesting stream history on stream subscription to historical streams #44505

Closed
kenzieschmoll opened this issue Dec 17, 2020 · 2 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-dds For issues related to the Dart Development Service

Comments

@kenzieschmoll
Copy link
Contributor

Streams for which we have historical data: https://github.com/dart-lang/sdk/blob/master/pkg/dds/dds_protocol.md#streams

Right now, DDS sends historical events upon the first stream subscription per client. In DevTools, we have multiple subscriptions from the same client, and would like to be able to request history upon stream subscription. I think adding an optional sendHistory param for onExtensionEvent, onLoggingEvent, onStderrEvent, and onStdoutEvent would work. Then DDS could send all history to the subscription based on the value of this parameter.

@kenzieschmoll kenzieschmoll added the pkg-dds For issues related to the Dart Development Service label Dec 17, 2020
@srawlins srawlins added the area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. label Dec 24, 2020
@bkonyi
Copy link
Contributor

bkonyi commented Dec 29, 2020

As discussed offline, DevTools subscribes to its streams immediately after the VM service connection is established and never resubscribes. I've gone ahead and added a getStreamHistory RPC instead which allows for clients to manually request history for a stream.

@kenzieschmoll
Copy link
Contributor Author

Would it be possible to add additional methods to dds onLoggingEventWithHistory for example, that stitch together the historical events and the new events? This would take the responsibility off the clients to do this manual stitching and could reduce the risk of dropping events or getting events out of order.

@bkonyi bkonyi reopened this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-dds For issues related to the Dart Development Service
Projects
None yet
Development

No branches or pull requests

3 participants