Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Restore tests that use package:linter #44737

Open
scheglov opened this issue Jan 21, 2021 · 1 comment
Open

[Migration] Restore tests that use package:linter #44737

scheglov opened this issue Jan 21, 2021 · 1 comment
Assignees
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-task

Comments

@scheglov
Copy link
Contributor

We use actual package:linter to verify that package:linter can generate lints, enable or disable them, change severity, etc. But with package:analyzer migrated, including its tests, we cannot import package:linter until it is migrated as well.

For now I will:

  1. Comment out imports of package:linter and registerLintRules() invocations.
  2. Mark corresponding tests as failing.
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on analyzer-technical-debt labels Jan 21, 2021
@scheglov scheglov changed the title [Migration] Restore tests that use package_linter [Migration] Restore tests that use package:linter Jan 21, 2021
@scheglov scheglov self-assigned this Jan 21, 2021
@srawlins
Copy link
Member

@scheglov do you know if this was finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-task
Projects
None yet
Development

No branches or pull requests

2 participants