Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage is slow on large projects #45985

Closed
dnfield opened this issue May 11, 2021 · 5 comments
Closed

Coverage is slow on large projects #45985

dnfield opened this issue May 11, 2021 · 5 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter P2 A bug or feature request we're likely to work on

Comments

@dnfield
Copy link
Contributor

dnfield commented May 11, 2021

Corresponds to internal bug b/179848548

See also flutter/flutter#81803

Getting coverage from the VM service involves multiple RPC calls that transfer megabytes worth of data per test. This becomes untenable for larger projects with lots of source files and lots of tests.

It seems like we could get a lot of mileage out of a single VM call (or flag) that would generate a more streamlined coverage file (perhaps even just an lcov file).

This bug blocks Flutter from being able to reasonably run coverage on CI without timing out or using a very very powerful machine.

/cc @twobitunicorn fyi
/cc @liamappelbe @a-siva

@dnfield dnfield added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter labels May 11, 2021
@a-siva a-siva added the P2 A bug or feature request we're likely to work on label May 12, 2021
@IchordeDionysos
Copy link

This might also block adding function and branch coverage, as I understand this also would require adding new RPC calls (at least for branch coverage).

See dart-lang/coverage#141 for more information.

@a-siva
Copy link
Contributor

a-siva commented Sep 13, 2021

Most of the discussion on improving coverage speed is happening in flutter/flutter#86722

@a-siva
Copy link
Contributor

a-siva commented Dec 1, 2021

@liamappelbe is more work expected on this issue ?

@liamappelbe
Copy link
Contributor

No. flutter/flutter#90142 halves the time it takes to gather coverage. And isolate groups have also helped because we only need to gather coverage once for the whole group. There's no other low hanging fruit I'm aware of, so we should close this and reopen if users are still having problems.

@creativecreatorormaybenot
Copy link
Contributor

@liamappelbe did you consider cherry-picking this into Flutter stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

5 participants