Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage failures on Fix orphaned files in tests/language/ and tests/language_2/. #46052

Open
6 of 9 tasks
dcharkes opened this issue May 18, 2021 · 2 comments
Open
6 of 9 tasks
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. gardening

Comments

@dcharkes
Copy link
Contributor

dcharkes commented May 18, 2021

Fix orphaned files in tests/language/ and tests/language_2/ enabled a bunch of test which were previously not enabled. We need to triage the crashing/failing/timing out VM tests:

  • language/regress/regress34091_test
  • language_2/regress/regress34091_test
  • language/vm/regression_38436_test
  • language_2/vm/regression_38436_test
  • language_2/vm/regression_38412_test
  • language/string/overflow_test
  • language_2/string/overflow_test
  • language/nnbd/static_errors/local_function_inference_test
  • language_2/nosuchmethod_forwarding/abstract_override_with_different_type_test

cc @munificent

@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. gardening crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. labels May 18, 2021
@dcharkes
Copy link
Contributor Author

dcharkes commented May 18, 2021

https://dart-ci.firebaseapp.com/current_results/#/filter=language/regress/regress34091_test

https://dart-ci.firebaseapp.com/current_results/#/filter=language/vm/regression_38436_test

https://dart-ci.firebaseapp.com/current_results/#/filter=language_2/vm/regression_38412_test

https://dart-ci.firebaseapp.com/current_results/#/filter=language/string/overflow_test

Missing out of memory errors.

https://dart-ci.firebaseapp.com/current_results/#/filter=language/nnbd/static_errors/local_function_inference_test

https://dart-ci.firebaseapp.com/current_results/#/filter=language_2/nosuchmethod_forwarding/abstract_override_with_different_type_test

@munificent
Copy link
Member

The change was reverted but I'm going to try to break it up into smaller pieces and re-land bits as I'm able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. crash Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash. gardening
Projects
None yet
Development

No branches or pull requests

2 participants