Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the range of legal radix string num.toRadixString #461

Closed
ghost opened this issue Nov 15, 2011 · 3 comments
Closed

Specify the range of legal radix string num.toRadixString #461

ghost opened this issue Nov 15, 2011 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.

Comments

@ghost
Copy link

ghost commented Nov 15, 2011

Currently implemented toRadixString for radix 1..16. Specify the range.

LibTest/core/int/toRadixString/int/toRadixString/A01/t01
@floitschG
Copy link
Contributor

EcmaScript goes up to 36. Any reason we shouldn't do the same?

@DartBot
Copy link

DartBot commented Dec 20, 2011

This comment was originally written by domi...@google.com

Whatever you do here, please reflect it in the String.toInt method.

@madsager
Copy link
Contributor

Fixed to go up to 36 on both implementation. Handling of out of bounds radices has been unified as well.

Added Fixed label.

@ghost ghost added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Sep 19, 2012
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madsager @floitschG @DartBot