Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Racy initialization of lazily populated ObjectStore members #46611

Closed
mkustermann opened this issue Jul 14, 2021 · 0 comments
Closed

Racy initialization of lazily populated ObjectStore members #46611

mkustermann opened this issue Jul 14, 2021 · 0 comments
Assignees
@mkustermann
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@mkustermann
Copy link
Member

From this log:

WARNING: ThreadSanitizer: data race (pid=16586)
  Write of size 8 at 0x7b6c00002b78 by thread T19:
    #0 dart::ObjectStore::LazyInitFutureTypes() ../../out/ReleaseTSANX64/../../runtime/vm/object_store.h:410 (dart+0x220b71e)
    #1 dart::ObjectStore::LazyInitFutureTypes() ../../out/ReleaseTSANX64/../../runtime/vm/object_store.cc:386 (dart+0x220b71e)
    #2 dart::AbstractType::NormalizeFutureOrType(dart::Heap::Space) const ../../out/ReleaseTSANX64/../../runtime/vm/object_store.h:410 (dart+0x21ab3af)
    #3 dart::AbstractType::NormalizeFutureOrType(dart::Heap::Space) const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:19711 (dart+0x21ab3af)
    #4 dart::kernel::TypeTranslator::BuildInterfaceType(bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_translation_helper.cc:3121 (dart+0x296948a)
    #5 dart::kernel::TypeTranslator::BuildTypeInternal() ??:? (dart+0x2968e62)
    #6 dart::kernel::TypeTranslator::BuildType() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_translation_helper.cc:3024 (dart+0x2960a2a)
    #7 dart::kernel::ScopeBuilder::VisitVariableDeclaration() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1363 (dart+0x2974d05)
    #8 dart::kernel::ScopeBuilder::VisitVariableDeclaration() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1315 (dart+0x2974d05)
    #9 dart::kernel::ScopeBuilder::VisitStatement() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1271 (dart+0x2974665)
    #10 dart::kernel::ScopeBuilder::VisitStatement() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1015 (dart+0x2973ae8)
    #11 dart::kernel::ScopeBuilder::VisitFunctionNode() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:553 (dart+0x2973116)
    #12 dart::kernel::ScopeBuilder::VisitNode() ??:? (dart+0x29720bc)
    #13 dart::kernel::ScopeBuilder::BuildScopes() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:231 (dart+0x296fd3a)
    #14 dart::ParsedFunction::EnsureKernelScopes() ../../out/ReleaseTSANX64/../../runtime/vm/parser.cc:133 (dart+0x220fb90)
    #15 dart::kernel::StreamingFlowGraphBuilder::ParseKernelASTFunction() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc:1045 (dart+0x2918b65)
    #16 dart::kernel::StreamingFlowGraphBuilder::BuildGraph() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc:983 (dart+0x2918889)
    #17 dart::kernel::FlowGraphBuilder::BuildGraph() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_to_il.cc:770 (dart+0x2937f32)
    #18 dart::DartCompilationPipeline::BuildFlowGraph(dart::Zone*, dart::ParsedFunction*, dart::ZoneGrowableArray<dart::ICData const*>*, long, bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:138 (dart+0x233553b)
    #19 dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:549 (dart+0x2336f62)
    #20 dart::CompileFunctionHelper(dart::CompilationPipeline*, dart::Function const&, bool, long) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:729 (dart+0x23380cf)
    #21 dart::Compiler::CompileFunction(dart::Thread*, dart::Function const&) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:859 (dart+0x2337af1)
    #22 dart::Function::EnsureHasCode() const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:10042 (dart+0x21714a7)
    #23 dart::DRT_HelperCompileFunction(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:231 (dart+0x2335bf2)
    #24 dart::DRT_CompileFunction(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:211 (dart+0x2335bf2)
    #25 <null> <null> (memfd:dart-codespace (deleted)+0x24b2)
    #26 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:147 (dart+0x2075fee)
    #27 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:37 (dart+0x207a1e7)
    #28 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:818 (dart+0x207a1e7)
    #29 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:1442 (dart+0x20c176c)
    #30 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:233 (dart+0x210c9ae)
    #31 dart::MessageHandler::TaskCallback() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:443 (dart+0x210d35f)
    #32 dart::MessageHandlerTask::Run() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:31 (dart+0x210dde3)
    #33 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x2318dca)
    #34 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2319865)
    #35 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x220e26d)

  Previous read of size 8 at 0x7b6c00002b78 by thread T9:
    #0 dart::AbstractType::NormalizeFutureOrType(dart::Heap::Space) const ../../out/ReleaseTSANX64/../../runtime/vm/tagged_pointer.h:80 (dart+0x21ab397)
    #1 <null> ../../out/ReleaseTSANX64/../../runtime/vm/object_store.h:410 (dart+0x21ab397)
    #2 dart::AbstractType::NormalizeFutureOrType(dart::Heap::Space) const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:19711 (dart+0x21ab397)
    #3 dart::kernel::TypeTranslator::BuildInterfaceType(bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_translation_helper.cc:3121 (dart+0x296948a)
    #4 dart::kernel::TypeTranslator::BuildTypeInternal() ??:? (dart+0x2968e62)
    #5 dart::kernel::TypeTranslator::BuildType() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_translation_helper.cc:3024 (dart+0x2960a2a)
    #6 dart::kernel::ScopeBuilder::VisitVariableDeclaration() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1363 (dart+0x2974d05)
    #7 dart::kernel::ScopeBuilder::VisitVariableDeclaration() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1315 (dart+0x2974d05)
    #8 dart::kernel::ScopeBuilder::VisitStatement() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1271 (dart+0x2974665)
    #9 dart::kernel::ScopeBuilder::VisitStatement() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:1015 (dart+0x2973ae8)
    #10 dart::kernel::ScopeBuilder::VisitFunctionNode() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:553 (dart+0x2973116)
    #11 dart::kernel::ScopeBuilder::VisitNode() ??:? (dart+0x29720bc)
    #12 dart::kernel::ScopeBuilder::BuildScopes() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/scope_builder.cc:231 (dart+0x296fd3a)
    #13 dart::ParsedFunction::EnsureKernelScopes() ../../out/ReleaseTSANX64/../../runtime/vm/parser.cc:133 (dart+0x220fb90)
    #14 dart::kernel::StreamingFlowGraphBuilder::ParseKernelASTFunction() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc:1045 (dart+0x2918b65)
    #15 dart::kernel::StreamingFlowGraphBuilder::BuildGraph() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc:983 (dart+0x2918889)
    #16 dart::kernel::FlowGraphBuilder::BuildGraph() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/frontend/kernel_to_il.cc:770 (dart+0x2937f32)
    #17 dart::DartCompilationPipeline::BuildFlowGraph(dart::Zone*, dart::ParsedFunction*, dart::ZoneGrowableArray<dart::ICData const*>*, long, bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:138 (dart+0x233553b)
    #18 dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:549 (dart+0x2336f62)
    #19 dart::CompileFunctionHelper(dart::CompilationPipeline*, dart::Function const&, bool, long) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:729 (dart+0x23380cf)
    #20 dart::Compiler::CompileFunction(dart::Thread*, dart::Function const&) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:859 (dart+0x2337af1)
    #21 dart::Function::EnsureHasCode() const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:10042 (dart+0x21714a7)
    #22 dart::DRT_HelperCompileFunction(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:231 (dart+0x2335bf2)
    #23 dart::DRT_CompileFunction(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:211 (dart+0x2335bf2)
    #24 <null> <null> (memfd:dart-codespace (deleted)+0x24b2)
    #25 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:147 (dart+0x2075fee)
    #26 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:37 (dart+0x207a1e7)
    #27 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:818 (dart+0x207a1e7)
    #28 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:1442 (dart+0x20c176c)
    #29 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:233 (dart+0x210c9ae)
    #30 dart::MessageHandler::TaskCallback() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:443 (dart+0x210d35f)
    #31 dart::MessageHandlerTask::Run() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:31 (dart+0x210dde3)
    #32 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x2318dca)
    #33 <null> <null> (memfd:dart-codespace (deleted)+0x24b2)
    #34 dart::JumpToExceptionHandler(dart::Thread*, unsigned long, unsigned long, unsigned long, dart::Object const&, dart::Object const&) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:584 (dart+0x20a6356)
    #35 dart::ThrowExceptionHelper(dart::Thread*, dart::Instance const&, dart::Instance const&, bool) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:768 (dart+0x20a6356)
    #36 dart::Exceptions::Throw(dart::Thread*, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:909 (dart+0x20a59c5)
    #37 dart::DRT_HelperThrow(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:1167 (dart+0x22b8983)
    #38 dart::DRT_Throw(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:1165 (dart+0x22b8983)
    #39 <null> <null> (memfd:dart-codespace (deleted)+0x24b2)
    #40 dart::JumpToExceptionHandler(dart::Thread*, unsigned long, unsigned long, unsigned long, dart::Object const&, dart::Object const&) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:584 (dart+0x20a6356)
    #41 dart::ThrowExceptionHelper(dart::Thread*, dart::Instance const&, dart::Instance const&, bool) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:768 (dart+0x20a6356)
    #42 dart::Exceptions::Throw(dart::Thread*, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/exceptions.cc:909 (dart+0x20a59c5)
    #43 dart::DRT_HelperThrow(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:1167 (dart+0x22b8983)
    #44 dart::DRT_Throw(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:1165 (dart+0x22b8983)
    #45 <null> <null> (memfd:dart-codespace (deleted)+0x24b2)
    #46 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:147 (dart+0x2075fee)
    #47 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:37 (dart+0x207a1e7)
    #48 dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:818 (dart+0x207a1e7)
    #49 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:1442 (dart+0x20c176c)
    #50 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:233 (dart+0x210c9ae)
    #51 dart::MessageHandler::TaskCallback() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:443 (dart+0x210d35f)
    #52 dart::MessageHandlerTask::Run() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:31 (dart+0x210dde3)
    #53 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x2318dca)
    #54 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2319865)
    #55 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x220e26d)
@mkustermann mkustermann added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Jul 14, 2021
@mkustermann mkustermann self-assigned this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkustermann