web_2/dummy_compiler_test is failing on all web backends

[nshahan]

Compile time error:

org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:16:8: Error: Error when reading 'org-dartlang-app:/tests/web_2/mock_libraries.dart': File not found
import 'mock_libraries.dart';
       ^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:20:12: Error: Undefined name 'DEFAULT_PLATFORM_CONFIG'.
    return DEFAULT_PLATFORM_CONFIG;
           ^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:23:31: Error: Undefined name 'DEFAULT_CORE_LIBRARY'.
    return buildLibrarySource(DEFAULT_CORE_LIBRARY);
                              ^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:23:12: Error: Method not found: 'buildLibrarySource'.
    return buildLibrarySource(DEFAULT_CORE_LIBRARY);
           ^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:25:12: Error: Undefined name 'DEFAULT_PATCH_CORE_SOURCE'.
    return DEFAULT_PATCH_CORE_SOURCE;
           ^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:27:31: Error: Undefined name 'DEFAULT_INTERNAL_LIBRARY'.
    return buildLibrarySource(DEFAULT_INTERNAL_LIBRARY);
                              ^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:27:12: Error: Method not found: 'buildLibrarySource'.
    return buildLibrarySource(DEFAULT_INTERNAL_LIBRARY);
           ^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:29:31: Error: Undefined name 'DEFAULT_INTERCEPTORS_LIBRARY'.
    return buildLibrarySource(DEFAULT_INTERCEPTORS_LIBRARY);
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:29:12: Error: Method not found: 'buildLibrarySource'.
    return buildLibrarySource(DEFAULT_INTERCEPTORS_LIBRARY);
           ^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:31:31: Error: Undefined name 'DEFAULT_JS_HELPER_LIBRARY'.
    return buildLibrarySource(DEFAULT_JS_HELPER_LIBRARY);
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:31:12: Error: Method not found: 'buildLibrarySource'.
    return buildLibrarySource(DEFAULT_JS_HELPER_LIBRARY);
           ^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:33:31: Error: Undefined name 'DEFAULT_ASYNC_LIBRARY'.
    return buildLibrarySource(DEFAULT_ASYNC_LIBRARY);
                              ^^^^^^^^^^^^^^^^^^^^^
org-dartlang-app:/tests/web_2/dummy_compiler_test.dart:33:12: Error: Method not found: 'buildLibrarySource'.
    return buildLibrarySource(DEFAULT_ASYNC_LIBRARY);
           ^^^^^^^^^^^^^^^^^^

[nshahan]

web/dummy_compiler_test as well.

[nshahan]

@sigmundch I'm trying to remember did you say that this test was obsolete and should be deleted?

[sigmundch]

/cc @joshualitt - I recall we had trouble with this test in the past, but I don't recall the reasons.

Seems the import to mock_libraries.dart broke when we shuffled files around in 05ca544, so we could try and see, if fixing the import would make the test pass again, then we can keep it. If not, I'm inclined to delete it since ensuring that we can run the compiler on the browser is not a goal at the moment.

[sigmundch]

Just checked, adding the import helps some, but not entirely. The test can be compiled, but fails at runtime because the inputs are very outdated and flags are not well configured. For example, it still depends on .platform (a predecessor to the libraries.json file) and fails trying to detect the location of the input .dill files.

We could try to fix those issues, but there may be more downstream. I don't feel it carries it's weight at the moment.

I am sending out https://dart-review.googlesource.com/c/sdk/+/219124 to delete it.

@joshualitt @rakudrama - let me know if you disagree :)