Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [vm] Improve Code cluster layout for startup #47971

Closed
mraleph opened this issue Dec 20, 2021 · 9 comments
Closed

Failures on [vm] Improve Code cluster layout for startup #47971

mraleph opened this issue Dec 20, 2021 · 9 comments
Assignees
@mraleph
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@mraleph
Copy link
Member

mraleph commented Dec 20, 2021

There are new test failures on [vm] Improve Code cluster layout for startup.

The tests

lib/mirrors/generic_f_bounded_mixin_application_test CompileTimeError (expected Pass)
standalone_2/dwarf_stack_trace_invisible_functions_test Fail (expected Pass)
standalone_2/dwarf_stack_trace_obfuscate_test Fail (expected Pass)
standalone_2/dwarf_stack_trace_test Fail (expected Pass)
standalone_2/fragmentation_deferred_load_test Fail (expected Pass)
standalone_2/io/client_socket_add_close_error_test Fail (expected Pass)
standalone_2/io/client_socket_add_close_no_error_test Fail (expected Pass)
standalone_2/io/client_socket_add_close_result_error_test Fail (expected Pass)
standalone_2/io/client_socket_add_destroy_no_error_test Fail (expected Pass)
standalone_2/io/echo_server_stream_test/0 Fail (expected Pass)
standalone_2/io/echo_server_stream_test/1 Fail (expected Pass)
standalone_2/io/echo_server_stream_test/2 Fail (expected Pass)
standalone_2/io/echo_server_stream_test/3 Fail (expected Pass)
standalone_2/io/file_fuzz_test Fail (expected Pass)
standalone_2/io/file_input_stream_test Fail (expected Pass)
standalone_2/io/file_test Fail (expected Pass)
standalone_2/io/file_write_as_test Fail (expected Pass)
standalone_2/io/http_10_test/0 Fail (expected Pass)
standalone_2/io/http_10_test/1 Fail (expected Pass)
standalone_2/io/http_10_test/2 Fail (expected Pass)
standalone_2/io/http_10_test/3 Fail (expected Pass)
standalone_2/io/http_auth_digest_test Fail (expected Pass)
standalone_2/io/http_auth_test Fail (expected Pass)
standalone_2/io/http_basic_test/0 Fail (expected Pass)
standalone_2/io/http_basic_test/1 Fail (expected Pass)
standalone_2/io/http_basic_test/2 Fail (expected Pass)
standalone_2/io/http_basic_test/3 Fail (expected Pass)
standalone_2/io/http_big_header_test Fail (expected Pass)
standalone_2/io/http_close_test/0 Fail (expected Pass)
standalone_2/io/http_close_test/1 Fail (expected Pass)
    and 156 more tests

are failing on configurations

dartk-strong-mac-debug-arm64
dartkp-ubsan-linux-release-x64
@mraleph mraleph added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Dec 20, 2021
@mraleph mraleph self-assigned this Dec 20, 2021
@a-siva
Copy link
Contributor

a-siva commented Dec 20, 2021

dartk-strong-linux-debug-ia32 has also started failing the test
lib/mirrors/generic_f_bounded_mixin_application_test CompileTimeError
though after a number of successful runs after ' [vm] Improve Code cluster layout for startup.' landed

@aam
Copy link
Contributor

aam commented Dec 21, 2021

@mraleph given large number of arm64 failures should 13d27d6 be reverted?

@mraleph
Copy link
Member Author

mraleph commented Dec 21, 2021

These failures are benign (at least on the platforms we work with) - and there is a relatively straightforward forward fix.

@aam
Copy link
Contributor

aam commented Dec 21, 2021

Is it not going to affect m1 flutter users?

@mraleph
Copy link
Member Author

mraleph commented Dec 21, 2021

It should not - M1 should support unaligned loads for integral values like any other ARM64. Why do you think it will break on M1?

@aam
Copy link
Contributor

aam commented Dec 21, 2021

Purely because the failures(crashes) are happening on mac arm64 buildbots. I thought those are m1 bots.

@mraleph
Copy link
Member Author

mraleph commented Dec 21, 2021

Purely because the failures(crashes) are happening on mac arm64 buildbots. I thought those are m1 bots.

I think the issue template that dart-ci dashboard uses is confusing. All the crashes except one (the first one) are from UBSAN. The first one is from ARM64 buildbot and it seems to be a compile time error that happens in all configurations - I doubt it is related to this issue at all.

@aam
Copy link
Contributor

aam commented Dec 21, 2021

Okay, I see. It looks like tests changed status when an attempt was made to upgrade xcode (#47948 that tracks that issues found with that failed attempt).

@alexmarkov
Copy link
Contributor

The following test began failing on vm-kernel-precomp-ubsan-linux-release-x64 with similar symptoms:

standalone_2/typed_array_test broke (Pass -> Fail, expected Pass)

../../runtime/vm/object.h:5985:22: runtime error: member access within misaligned address 0x7fdc9fe9cc51 for type 'const UntaggedCompressedStackMaps::Payload', which requires 4 byte alignment
0x7fdc9fe9cc51: note: pointer points here
 32 12 21  15 d2 00 00 00 43 24 2c  4c 0a 24 29 24 42 4c 15  ee 0c 11 95 01 67 4c 24  85 02 14 82 05
              ^ 
    #0 0x560b999695ab in dart::CompressedStackMaps::RawPayloadHandle::UsesGlobalTable() const ../../out/ReleaseUBSANX64/../../runtime/vm/object.h:5985:22
    #1 0x560b999695ab in dart::CompressedStackMaps::Iterator<dart::CompressedStackMaps::RawPayloadHandle>::Iterator(dart::CompressedStackMaps::RawPayloadHandle const&, dart::CompressedStackMaps::RawPayloadHandle const&) ../../out/ReleaseUBSANX64/../../runtime/vm/object.h:6002:32
    #2 0x560b999695ab in dart::StackFrame::VisitObjectPointers(dart::ObjectPointerVisitor*) ../../out/ReleaseUBSANX64/../../runtime/vm/stack_frame.cc:243:74
    #3 0x560b99981f40 in dart::Thread::VisitObjectPointers(dart::ObjectPointerVisitor*, dart::ValidationPolicy) ../../out/ReleaseUBSANX64/../../runtime/vm/thread.cc:637:14
    #4 0x560b997ca26d in dart::IsolateGroup::VisitStackPointers(dart::ObjectPointerVisitor*, dart::ValidationPolicy) ../../out/ReleaseUBSANX64/../../runtime/vm/isolate.cc:2961:33
    #5 0x560b997c9eba in dart::IsolateGroup::VisitObjectPointers(dart::ObjectPointerVisitor*, dart::ValidationPolicy) ../../out/ReleaseUBSANX64/../../runtime/vm/isolate.cc:2899:3
    #6 0x560b999d3416 in dart::Scavenger::IterateIsolateRoots(dart::ObjectPointerVisitor*) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:1154:27
    #7 0x560b999d82d9 in void dart::Scavenger::IterateRoots<true>(dart::ScavengerVisitorBase<true>*) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:1222:9
    #8 0x560b999d7d6a in dart::ScavengerVisitorBase<true>::ProcessRoots() ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:238:19
    #9 0x560b999d61e7 in dart::ParallelScavengerTask::RunEnteredIsolateGroup() ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:589:15
    #10 0x560b999d52fa in dart::Scavenger::ParallelScavenge(dart::SemiSpace*) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:1717:12
    #11 0x560b999d49ac in dart::Scavenger::Scavenge(dart::GCReason) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/scavenger.cc:1642:22
    #12 0x560b999b6ab4 in dart::Heap::CollectNewSpaceGarbage(dart::Thread*, dart::GCReason) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/heap.cc:473:18
    #13 0x560b999b5c18 in dart::Heap::AllocateNew(long) ../../out/ReleaseUBSANX64/../../runtime/vm/heap/heap.cc:82:5
    #14 0x560b99815aff in dart::Object::Allocate(long, long, dart::Heap::Space, bool) ../../out/ReleaseUBSANX64/../../runtime/vm/object.cc:2636:25
    #15 0x560b99875539 in dart::Array::New(long, long, dart::Heap::Space) ../../out/ReleaseUBSANX64/../../runtime/vm/object.cc:24270:9
    #16 0x560b9980f35b in dart::Array::New(long, dart::Heap::Space) ../../out/ReleaseUBSANX64/../../runtime/vm/object.cc:24242:21
    #17 0x560b99793849 in dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&) ../../out/ReleaseUBSANX64/../../runtime/vm/dart_entry.cc:722:12
    #18 0x560b997c3c22 in dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseUBSANX64/../../runtime/vm/isolate.cc:1418:15
    #19 0x560b997d98b1 in dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseUBSANX64/../../runtime/vm/message_handler.cc:240:16
    #20 0x560b997da604 in dart::MessageHandler::TaskCallback() ../../out/ReleaseUBSANX64/../../runtime/vm/message_handler.cc:450:18
    #21 0x560b99988ed7 in dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseUBSANX64/../../runtime/vm/thread_pool.cc:174:15
    #22 0x560b99989873 in dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseUBSANX64/../../runtime/vm/thread_pool.cc:339:9
    #23 0x560b998ce668 in dart::ThreadStart(void*) ../../out/ReleaseUBSANX64/../../runtime/vm/os_thread_linux.cc:154:5
    #24 0x7fdca0adc6da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
    #25 0x7fdca025f71e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x12171e)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../runtime/vm/object.h:5985:22 in

--- Re-run this test:
python3 tools/test.py -n dartkp-ubsan-linux-release-x64 standalone_2/typed_array_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mraleph mraleph

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @aam @a-siva @alexmarkov