Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] TTS_Regress_CidRangeChecks manual cid updates #48673

Closed
dcharkes opened this issue Mar 26, 2022 · 0 comments
Closed

[test] TTS_Regress_CidRangeChecks manual cid updates #48673

dcharkes opened this issue Mar 26, 2022 · 0 comments
Assignees
@sstrickl
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@dcharkes
Copy link
Contributor

We should investigate if we can update TTS_Regress_CidRangeChecks to compute kNumUnrelated instead of manually updating it every time we add a class to a dart: library.

This would prevent churn on:

Suggested approach: Check the cid of the first class, and compute it from there.
@dcharkes dcharkes added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sstrickl sstrickl

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sstrickl @dcharkes