Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 9266: Channel Bindings for TLS 1.3 support #49581

Open
Neustradamus opened this issue Aug 2, 2022 · 8 comments
Open

RFC 9266: Channel Bindings for TLS 1.3 support #49581

Neustradamus opened this issue Aug 2, 2022 · 8 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-flutter library-io type-enhancement A request for a change that isn't a bug

Comments

@Neustradamus
Copy link

Can you add the support of RFC 9266: Channel Bindings for TLS 1.3?

Little details, to know easily:

  • tls-unique for TLS =< 1.2
  • tls-exporter for TLS = 1.3

Thanks in advance.

@mit-mit mit-mit added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Aug 3, 2022
@mit-mit
Copy link
Member

mit-mit commented Aug 3, 2022

cc @brianquinlan

@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. library-io labels Aug 3, 2022
@a-siva
Copy link
Contributor

a-siva commented Aug 8, 2022

//cc @brianquinlan

@brianquinlan
Copy link
Contributor

@Neustradamus It wasn't clear from the BoringSSL bug (openssl/openssl#18893) that you filed whether the necessary BoringSSL features are in place - are they?

@Neustradamus
Copy link
Author

@brianquinlan: About BoringSSL, it is not complete, you can compare:
1/ tls-unique:

2/ tls-exporter:

From @agl, @davidben: tls-unique:

I have commented here:

I have requested more details:

Can you add more details like for previous "RFC5929":
- https://github.com/google/boringssl/search?q=rfc5929
- https://github.com/google/boringssl/search?q=tls-unique

Because we find nothing about: "RFC9266":
- https://github.com/google/boringssl/search?q=rfc9266
- https://github.com/google/boringssl/search?q=tls-exporter

@davidben
Copy link
Contributor

davidben commented Aug 10, 2022

@Neustradamus, as I explained in the other places you've been CCing us, no new APIs are needed to implement RFC 9266, in any of OpenSSL or its derivatives. Or, indeed, in most TLS libraries I expect. You simply call the existing APIs for TLS's "export keying material" mechanism. Any API specific to RFC 9266 would just be convenience wrappers over that underlying primitive.

I don't see a particular need to add a convenience wrapper to BoringSSL right now.

@Neustradamus
Copy link
Author

@PapaTutuWawa: I have done ticket here, do not hesitated to explain your problem.

Linked to:

@PapaTutuWawa
Copy link

The issue comes from the fact that I would like to use TLS Channel Binding in my application using Dart to implement SCRAM-*-PLUS. For that, however, I would need access to the TLS connection's state (if that is the correct name) to get the neccessary data. Taking this Go SCRAM implementation as inspiration, something like Go's ExportKeyingMaterial would be required. As far as I know, Dart does not expose this kind of access in the SecureSocket class.

@a-siva a-siva added type-enhancement A request for a change that isn't a bug and removed area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Nov 4, 2022
@Neustradamus
Copy link
Author

Happy New Year 2023 to all!

Have you looked for this ticket and the @PapaTutuWawa comment?

@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-flutter library-io type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants