Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [parser] Breaking change for metadata parsing #50769

Closed
jensjoha opened this issue Dec 19, 2022 · 4 comments
Closed

Failures on [parser] Breaking change for metadata parsing #50769

jensjoha opened this issue Dec 19, 2022 · 4 comments
Assignees
@munificent
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-format Issues related to the 'dart format' tool

Comments

@jensjoha
Copy link
Contributor

There are new test failures on [parser] Breaking change for metadata parsing.

The test

dart_style/test/formatter_test RuntimeError (expected Pass)

is failing.

/cc @munificent
@jensjoha
Copy link
Contributor Author

The same thing - I'm guessing - is also run internally and causes go/dart-cbuild result: FAILURE (REGRESSIONS DETECTED).

@lrhn lrhn added dart-cli-format Issues related to the 'dart format' tool area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. labels Dec 19, 2022
@munificent
Copy link
Member

I'll take a look.

@munificent
Copy link
Member

Fix out: dart-lang/dart_style#1154

@munificent
Copy link
Member

...and CL out to roll the fix into the SDK: https://dart-review.googlesource.com/c/sdk/+/276681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-format Issues related to the 'dart format' tool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@munificent @lrhn @jensjoha