Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove experimental annotation from @reopen before publishing (for 3.0) #51059

Closed
pq opened this issue Jan 18, 2023 · 3 comments
Closed

remove experimental annotation from @reopen before publishing (for 3.0) #51059

pq opened this issue Jan 18, 2023 · 3 comments
Assignees
@pq
Labels
analyzer-pkg-meta Issues related to package:meta area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone
Dart 3 beta 3

Comments

@pq
Copy link
Member

pq commented Jan 18, 2023

Before we do a package:meta release for Dart 3.0, we'll want to remove the experimental tag from the @reopen declaration.

See: https://dart-review.googlesource.com/c/sdk/+/278888
@pq pq added the analyzer-pkg-meta Issues related to package:meta label Jan 18, 2023
@pq pq added this to the Dart 3 beta 3 milestone Jan 18, 2023
@pq pq added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Jan 18, 2023
@a-siva a-siva added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 19, 2023
@itsjustkevin
Copy link
Contributor

@pq seems like this is merged, is there any other work required before closing this issue?

@pq
Copy link
Member Author

pq commented Mar 6, 2023

We've still got it marked @experimental so we'll want to keep this one open for now...

@pq
Copy link
Member Author

pq commented Mar 21, 2023

This one is gated behind dart-lang/linter#3920.

Assuming that lands we can/should do this.

If it doesn't, we'll want to update the docs to not promote the lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
analyzer-pkg-meta Issues related to package:meta area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
3 participants
@pq @a-siva @itsjustkevin