Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Avoid confusing sdk-ranges in pub solve-error messages. #51101

Closed
sigurdm opened this issue Jan 23, 2023 · 7 comments
Closed

[CP] Avoid confusing sdk-ranges in pub solve-error messages. #51101

sigurdm opened this issue Jan 23, 2023 · 7 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-tools A general category for issues that we think should be addressed by tooling. cherry-pick-approved Label for approved cherrypick request merge-to-stable

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Jan 23, 2023 •
edited

Commit(s) to merge

(Has not been merged to main yet)

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/279509

Issue Description

Pub can show wrong/misleading/confusing ranges for unfulfilled sdk constraints in 2.19.

We introduced an sdk rewrite to allow dart 3 to be compatible with dart 2.12 and later, such that internally it treats constraints like >=2.12.0 <3.0.0 as >=2.12.0 <4.0.0. But that was landed already in 2.19, where a constraint like >=2.19.5 <3.0.0 might give a message like:

Because library requires SDK version >=2.19.0-beta.1 <4.0.0, version solving failed.

Details:
dart-lang/pub#3738

What is the fix

We disable the logic for treating >=2.12.0 <3.0.0 as >=2.12.0 <4.0.0 for the 2.19 branch.

Why cherry-pick

This has no functional consequences, but can lead to confusing error messages.

Risk

low

Issue link(s)

dart-lang/pub#3738

Extra Info

No response
@sigurdm sigurdm added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 23, 2023
@sigurdm
Copy link
Contributor Author

sigurdm commented Jan 23, 2023

CC @athomas

@mit-mit
Copy link
Member

mit-mit commented Jan 23, 2023

SGTM

@athomas
Copy link
Member

athomas commented Jan 23, 2023

I'm not sure this meets the bar for release blocker, because it's just an incorrect error message with no functional consequences. We're running the CQ now and will make a call on merging this around 16:00. This could go into a stable hotfix as well.

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Jan 23, 2023 •
edited

It would take an extremely detrimental bug for us to feel comfortable cherry-picking into a stable release.

I am leaning toward pushing this to a fast follow stable hot fix over cherry-picking into the release.

Could we change the geritt CL to run against the stable branch instead?

@athomas
Copy link
Member

athomas commented Jan 23, 2023

Agreed. Let's defer this to 2.19.1 stable.

@a-siva a-siva added the area-tools A general category for issues that we think should be addressed by tooling. label Jan 23, 2023
@athomas
Copy link
Member

athomas commented Jan 24, 2023

SGTM for stable, marking this as approved.

@athomas athomas added cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-review Issue that need cherry pick triage to approve labels Jan 24, 2023
@sortie
Copy link
Contributor

sortie commented Feb 2, 2023

Released in 2.19.1.

@sortie sortie closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-tools A general category for issues that we think should be addressed by tooling. cherry-pick-approved Label for approved cherrypick request merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@vsmenon @sortie @whesse @sigurdm @a-siva @itsjustkevin @mit-mit @athomas