Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gardening] pkg/dartdev tests failing on Windows #51927

Open
dcharkes opened this issue Apr 3, 2023 · 0 comments
Open

[gardening] pkg/dartdev tests failing on Windows #51927

dcharkes opened this issue Apr 3, 2023 · 0 comments
Assignees
@keertip @sigurdm
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dart-cli-compile Issues related to the 'dart compile' tool gardening os-windows

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Apr 3, 2023

There are new test failures on Add support for patterns to replace null assert with cast fix...Resolve package pubspec of target for relevant dartdev commands.

The tests

pkg/dartdev/test/commands/compile_test RuntimeError (expected Pass)
pkg/dartdev/test/commands/doc_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win

@sigurdm @keertip there are two dartdev CLs in this range. The regression might have gone unnoticed as it's only on Windows.

Logs:

I have approved the failures, PTAL at the regression.
@dcharkes dcharkes added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. os-windows gardening dart-cli-compile Issues related to the 'dart compile' tool labels Apr 3, 2023
@dcharkes dcharkes changed the title Failures on Add support for patterns to replace null assert with cast fix...Resolve package pubspec of target for relevant dartdev commands [gardening] pkg/dartdev tests failing on Windows Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

@sigurdm sigurdm

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. dart-cli-compile Issues related to the 'dart compile' tool gardening os-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keertip @dcharkes @sigurdm