Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pkg/dap for the use_super_parameters lint #53600

Closed
devoncarew opened this issue Sep 25, 2023 · 1 comment
Closed

update pkg/dap for the use_super_parameters lint #53600

devoncarew opened this issue Sep 25, 2023 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation pkg-dds For issues related to the Dart Development Service

Comments

@devoncarew
Copy link
Member

devoncarew commented Sep 25, 2023

We're excluding pkg/dap from using the new use_super_parameters due to some work required in the code generator (the generated code is triggering the lint). This issue tracks updating the generator and generator code (the work is not expected to be great).

cc @DanTup

@devoncarew devoncarew added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Sep 25, 2023
@DanTup DanTup added pkg-dds For issues related to the Dart Development Service dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation labels Sep 25, 2023
@DanTup
Copy link
Collaborator

DanTup commented Sep 25, 2023

Is there not a label to use for package:dap issue?

The DAP implementation is still in DDS (only the protocol classes were moved out into their own package), so the label is (at least currently) dds-dap. It doesn't seem entirely appropriate for this though :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. dds-dap DDS issues related to the Debug Adapter Protocol (DAP) implementation pkg-dds For issues related to the Dart Development Service
Projects
None yet
Development

No branches or pull requests

2 participants