quick fix for unawaited_futures inserts and invalid await in a cascade

[natebosch]

class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something(); // unawaited_futures
}

Running the quick fix "Add 'await' keyword" results in invalid code.

class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()await ..something(); // expected to find ';'
}

An alternative fix to suggest could be to ignore the future, but I'm not sure if it's a good idea to offer that. WDYT @lrhn

class C {
  Future<String> something() {
    return Future.value('hello');
  }
}

void main() async {
  C()..something().ignore();
}

[lrhn]

I think ignore may be the best we can do for now.

The problem with a cascade invocation of an async function, is that the value is never available as an expression, so there is no way to wrap in unawaited or await.

We could add something, but the real answer here is "if it hurts, stop doing it!".
You shouldn't call an async function that way, just make it a non-cascade, and treat the future properly.
Or use ignore, which is safer than unawaited if an error actually happens.

Or wait for us to finally add a suffix .await.

Today: use ignore, rewrite to not be a cascade, or refuse to do anything.
Either it's fine with me.

[bwilkerson]

We could certainly write a fix (or extend the existing fix) to split the cascade appropriately so that an await could be added, but I suspect that this case won't come up very often and that we're better off just disabling the fix for invocations in cascades.

[natebosch]

we're better off just disabling the fix for invocations in cascades.

This SGTM as well.

[hugo555686]

We could certainly write a fix (or extend the existing fix) to split the cascade appropriately so that an await could be added, but I suspect that this case won't come up very often and that we're better off just disabling the fix for invocations in cascades.

I'm sorry, I have no idea about things here, I didn't mean to make a mistake on purpose.