Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on [vm/ffi] Example with deeply-immutable Finalizable and dart_api_dl #55165

Closed
bkonyi opened this issue Mar 11, 2024 · 1 comment
Closed
Assignees

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Mar 11, 2024

There are new test failures on [vm/ffi] Example with deeply-immutable Finalizable and dart_api_dl.

The tests

ffi/deeply_immutable_c_api_finalizer_test Timeout (expected Pass)

are failing on configurations

vm-win-debug-x64
@dcharkes
Copy link
Contributor

dcharkes commented Mar 11, 2024

Log: https://dart-ci.appspot.com/log/vm-win-debug-x64/vm-win-debug-x64/3530/ffi/deeply_immutable_c_api_finalizer_test

stdout:
Instance of 'MyFinalizable'
Pointer: address=0x1d72074e060
123

The test output is being printed, but the main function doesn't seem to exit.

I'm suspecting the issue is allocating with package:ffi with CoTaskMemAlloc and then calling free.
We should allocate on Windows with the calloc that's linked in ffi_test_functions instead of looking up CoTaskMemAlloc.

CL: https://dart-review.googlesource.com/c/sdk/+/356801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants