Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dart2wasm] Include the text of the condition when throwing an assertion #55317

Closed
eyebrowsoffire opened this issue Mar 27, 2024 · 3 comments
Closed

[dart2wasm] Include the text of the condition when throwing an assertion #55317

eyebrowsoffire opened this issue Mar 27, 2024 · 3 comments
Assignees
@eyebrowsoffire
Labels
area-dart2wasm Issues for the dart2wasm compiler.

Comments

@eyebrowsoffire
Copy link
Contributor

When dart2wasm throws an assertion, it just throws "assertion failed" but does not include the text of the condition like other backends do. We should do this, some flutter framework tests rely on it.
@parlough parlough added the area-dart2wasm Issues for the dart2wasm compiler. label Mar 27, 2024
@eyebrowsoffire eyebrowsoffire self-assigned this Mar 29, 2024
@eyebrowsoffire
Copy link
Contributor Author

I have a fix out for review: https://dart-review.googlesource.com/c/sdk/+/360460

@rakudrama
Copy link
Member

FWIW, dart2js does not include the file / line / condition.
@eyebrowsoffire are these flutter framework tests never run on dart2js?

@eyebrowsoffire
Copy link
Contributor Author

@rakudrama That is correct, they are only compiled via DDC (and now dart2wasm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyebrowsoffire eyebrowsoffire

Labels
area-dart2wasm Issues for the dart2wasm compiler.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakudrama @parlough @eyebrowsoffire