Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dart2wasm] Get rid of the warning that compiling to WasmGC is experimental. #55526

Closed
kevmoo opened this issue Apr 19, 2024 · 3 comments
Closed

[dart2wasm] Get rid of the warning that compiling to WasmGC is experimental. #55526

kevmoo opened this issue Apr 19, 2024 · 3 comments
Assignees
@mit-mit
Labels
area-dart2wasm Issues for the dart2wasm compiler. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kevmoo
Copy link
Member

kevmoo commented Apr 19, 2024

sdk/pkg/dartdev/lib/src/commands/compile.dart

Lines 695 to 697 in 1998c87

log.stdout('*NOTE*: Compilation to WasmGC is experimental.');
log.stdout(
'The support may change, or be removed, with no advance notice.\n');

We are no longer experimental.
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) area-dart2wasm Issues for the dart2wasm compiler. labels Apr 19, 2024
@ditman ditman changed the title [dart2wasm] We should get rid of this this message! [dart2wasm] We should get rid of this message! Apr 19, 2024
@ditman ditman changed the title [dart2wasm] We should get rid of this message! [dart2wasm] Get rid of the warning that compiling to WasmGC is experimental. Apr 19, 2024
@osa1
Copy link
Member

osa1 commented Apr 23, 2024

Another mention of "experimental" here:

sdk/pkg/dartdev/lib/src/commands/compile.dart

Lines 542 to 543 in c78ad94

static const String help =
'Compile Dart to a WebAssembly/WasmGC module (EXPERIMENTAL).';

@kevmoo
Copy link
Member Author

kevmoo commented Apr 23, 2024

We should ditch both!

@kevmoo kevmoo added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Apr 23, 2024
@kevmoo
Copy link
Member Author

kevmoo commented May 6, 2024

@mit-mit is cranking on https://dart-review.googlesource.com/c/sdk/+/365462

@mit-mit mit-mit self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mit-mit mit-mit

Labels
area-dart2wasm Issues for the dart2wasm compiler. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @osa1 @mit-mit