Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider EXTRANEOUS_MODIFIER diagnostic improvements #55814

Open
pq opened this issue May 22, 2024 · 0 comments
Open

Consider EXTRANEOUS_MODIFIER diagnostic improvements #55814

pq opened this issue May 22, 2024 · 0 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-front-end Use area-front-end for front end / CFE / kernel format related issues. cfe-messages Poor/undesirable messaging in errors/warnings emitted by the CFE. fe-analyzer-shared-parser Issues with the shared parser's handling of correct code P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented May 22, 2024

In https://dart-review.googlesource.com/c/sdk/+/367540, I removed a bunch of unused diagnostics that are hold-overs from the analyzer's parser. They're dead so removing them is the right thing to do but the messages they provided are arguably better than the more generic shared one produced by the EXTRANEOUS_MODIFIER catch-all produced by the shared parser.

This issue is a place-holder if we decide to revisit.

/fyi @stereotype441 @bwilkerson
@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request area-front-end Use area-front-end for front end / CFE / kernel format related issues. fe-analyzer-shared-parser Issues with the shared parser's handling of correct code labels May 22, 2024
@johnniwinther johnniwinther added the cfe-messages Poor/undesirable messaging in errors/warnings emitted by the CFE. label May 23, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-front-end Use area-front-end for front end / CFE / kernel format related issues. cfe-messages Poor/undesirable messaging in errors/warnings emitted by the CFE. fe-analyzer-shared-parser Issues with the shared parser's handling of correct code P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @johnniwinther