Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to not_a_type diagnostics #55947

Open
natebosch opened this issue Jun 5, 2024 · 1 comment
Open

Add more context to not_a_type diagnostics #55947

natebosch opened this issue Jun 5, 2024 · 1 comment
Labels
analyzer-ux area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. improve-diagnostics Related to the quality of diagnostic messages P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@natebosch
Copy link
Member

natebosch commented Jun 5, 2024

Some time back the analyzer improved argument_type_not_assignable (and I'd imagine others) diagnostics to include more context about the types. Specifically it will say something like "where WhateverType is defined in URI".

Can we add similar context to not_a_type diagnostics? There should be a reference to a non-Type that we can point to.

@natebosch natebosch added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. improve-diagnostics Related to the quality of diagnostic messages labels Jun 5, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Jun 7, 2024
@srawlins
Copy link
Member

CC @bwilkerson

@srawlins srawlins added analyzer-ux P2 A bug or feature request we're likely to work on labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-ux area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. improve-diagnostics Related to the quality of diagnostic messages P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants