Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need tests for code that determines what files are published with a package #7391

Closed
munificent opened this issue Dec 13, 2012 · 9 comments
Closed
Assignees
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@munificent
Copy link
Member

The code for getting the list of files to include in a package has a bunch of interesting corners related to symlinks, git, etc. We've seen a few issues there where it doesn't give us the files we expect, and we don't have good test coverage for it. We should. In particular:

  1. Make sure packages directories are excluded.
  2. Make sure symlinks are handled correctly.
  3. Make sure .gitignored files are ignored.
  4. Make sure .gitignored directories (and their contents) are ignored.
  5. Make sure "." files are ignored in non-git packages.
@munificent
Copy link
Member Author

  1. Make sure "pubspec.lock" is always omitted.

@munificent
Copy link
Member Author

Removed Type-Defect label.
Added Type-Enhancement label.

@munificent
Copy link
Member Author

Removed this from the M3 milestone.
Added this to the M4 milestone.

@nex3
Copy link
Member

nex3 commented Mar 20, 2013

We should test this as part of our "pub lish" integration tests, but right now we have no way of parsing a multipart/form-data request.


Marked this as being blocked by #2488.

@sgjesse
Copy link
Contributor

sgjesse commented Apr 16, 2013

Marked this as being blocked by #8834.
Unmarked this as being blocked by #2488.

@munificent
Copy link
Member Author

Removed this from the M4 milestone.
Added this to the M5 milestone.

@nex3
Copy link
Member

nex3 commented May 15, 2013

Set owner to @nex3.
Added Started label.

@nex3
Copy link
Member

nex3 commented May 21, 2013

Fixed by r22807.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#377.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants