Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for the latest version of extension types #100

merged 2 commits into from Aug 21, 2023


Copy link

@devoncarew devoncarew commented Aug 21, 2023

  • updates for the latest version of extension types

This addresses a recent analysis issue - lib/node/process.dart:17:21 - Extension types can't declare instance fields. Try replacing the field with a getter. - extension_type_declares_instance_field.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

srujzs commented Aug 21, 2023

I'm okay with this (especially since we don't use it a setter), but note that this an error in the analyzer that I filed an issue for: dart-lang/sdk#53226.

Copy link
Member Author

Ah! I would like to land as that'll get the CI green, but it sounds like this is a workaround for an analyzer / extension types issue.

@devoncarew devoncarew merged commit e58aeb6 into main Aug 21, 2023
24 checks passed
@devoncarew devoncarew deleted the update_extension_types_usage branch August 21, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants