Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugging issues around specifying the latest patch release #108

Merged
merged 12 commits into from Oct 11, 2023

Conversation

devoncarew
Copy link
Member

  • debugging issues around specifying the latest patch release

Investigation around #107.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

Note that the build failure here is due to the action now requiring 3.3.0-0 to build, but the dev channel is not yet on a 3.3.0 version. This doesn't effect the behavior of the action itself, just our build validation bot.

.github/workflows/dart.yml Outdated Show resolved Hide resolved
pubspec.yaml Show resolved Hide resolved
// back to a double.
if (int.tryParse(sdk) != null && !sdk.contains('.')) {
// Convert a '3' to a '3.0'.
sdk = '$sdk.0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd throw instead. We didn't intend to support only a 3 value. This case means there was a user error and the intended minor version got lost.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, what's happening is the user has entered a 3.0 in their yaml file. That gets converted (by the yaml parser? by the javascript runtime?) into a 3 before we get the value. So all we see here is a 3, and have to infer that what they likely had actually written was a 3.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this workaround we would be able to support values of 3.1, 3.2, ..., but not of 3.0.

lib/main.dart Outdated Show resolved Hide resolved
@devoncarew
Copy link
Member Author

Thanks for the reviews; updated for review feedback and for a fix from #107 (comment).

.github/workflows/build.yml Outdated Show resolved Hide resolved
@athomas
Copy link
Member

athomas commented Oct 11, 2023

FYI, build is still failing because of the 3.3.0-0 SDK requirement. It will start working on Thu when the first 3.3 dev release gets published.

@devoncarew devoncarew merged commit b64355a into main Oct 11, 2023
26 of 27 checks passed
@devoncarew devoncarew deleted the fixes_latest_patch branch October 11, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants