Update Transfer-Encoding logic. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efortuna
approved these changes
Dec 6, 2016
| if (coding != null && !equalsIgnoreAsciiCase(coding, 'identity')) { | ||
| // If the response is already in a chunked encoding, de-chunk it because | ||
| // otherwise `dart:io` will try to add another layer of chunking. See | ||
| // sdk#27886. |
There was a problem hiding this comment.
gross. (the issue)
Maybe add a TODO to remove this branch afterwards?
This should be the last CL in this unfortunate series. The adapter requirements have been updated to consistently ensure that a Message's body is in the chunked format if and only if its headers indicate that it should be. Closes #64
nex3
force-pushed
the
transfer-encoding
branch
from
97d931f
to
31e7ebf
Compare
natebosch
added a commit
that referenced
this pull request
May 3, 2022
Reduce nesting by extracting to a method allowing guard clauses and inverted the conditionals with early returns. Remove some comments that repeat the code. Use conditional map elements and `..[]` operator to reduce the noise around setting headers. Add tests for requests where the range header is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last CL in this unfortunate series. The adapter
requirements have been updated to consistently ensure that a Message's
body is in the chunked format if and only if its headers indicate that
it should be.
Closes #64