Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO(miquelbeltran) Maybe ! would be better here #3295

Closed
vendz opened this issue Jun 3, 2021 · 1 comment · Fixed by #3456
Closed

TODO(miquelbeltran) Maybe ! would be better here #3295

vendz opened this issue Jun 3, 2021 · 1 comment · Fixed by #3456
Labels
a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@vendz
Copy link
Contributor

vendz commented Jun 3, 2021 •
edited

TODO link: https://github.com/dart-lang/site-www/blob/master/null_safety_examples/misc/test/language_tour/browser_test.dart#L16
@parlough parlough added e0-minutes Can complete in < 60 minutes of normal, not dedicated, work a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety p2-medium Necessary but not urgent concern. Resolve when possible. labels Jun 3, 2021
@parlough
Copy link
Member

parlough commented Jun 3, 2021

Thanks for making an issue to track this TODO! The question raised in this TODO is a good question and if anyone has any suggestions I'm open to them. I'm thinking since we know the div should be there, it's safe to use ! in this case.

parlough added a commit to parlough/site-www that referenced this issue Aug 6, 2021
@parlough
Remove unused code excerpt
ad551fc 
Closes dart-lang#3295
@parlough parlough mentioned this issue Aug 6, 2021
Merged
kwalrath pushed a commit that referenced this issue Aug 9, 2021
@parlough
Remove unused code excerpt (#3456)
c42a166 
Closes #3295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a.language Relates to the Dart language tour dev.null-safety Relates to transforming or migrating Dart code to sound null safety e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused code excerpt parlough/site-www
2 participants
@parlough @vendz