-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing code example in futures-error-handling guide #373
Labels
fix.bug
Needs fix of incorrect copy, code, or visual
Comments
I agree that it is so misleading that it's probably just wrong. The |
@BorisNaguet you've convinced me that the page should feature DartPad. (I think its original version was from before DartPad's existence.) |
Yes, this piece was written years ago by our DPE, and long before DartPad existed. I think it's a great idea! |
Related to #407. |
20 tasks
chalin
added a commit
to chalin/site-www
that referenced
this issue
Dec 15, 2017
chalin
added a commit
to chalin/site-www
that referenced
this issue
Dec 15, 2017
chalin
added a commit
that referenced
this issue
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
on this page:
https://www.dartlang.org/guides/libraries/futures-error-handling#completing-the-future-returned-by-whencomplete
this example:
It's confusing, because "Won't reach here, or here, nor here" seems to mean that it won't be printed.
But "... or here..." is actually printed (but the error is transmitted on the next Future as the comments explain correctly).
I think it would be clearer with an executable code in dartpad like on other parts of the site.
The text was updated successfully, but these errors were encountered: