Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite mixins page #4871

Closed
MaryaBelanger opened this issue May 11, 2023 · 1 comment · Fixed by #5694
Closed

Rewrite mixins page #4871

MaryaBelanger opened this issue May 11, 2023 · 1 comment · Fixed by #5694
Assignees
Labels
a.language Relates to the Dart language tour e2-days Can complete in < 5 days of normal, not dedicated, work fix.quality Needs improvement in copy quality from.team Reported by Dash docs team member p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@MaryaBelanger
Copy link
Contributor

Rewrite/rearrange contents on mixins page in a more sensible way, details in these comments: #4834 (comment)

@danagbemava-nc danagbemava-nc added st.triage.triage-team Triage team reviewing and categorizing the issue p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Can complete in < 5 days of normal, not dedicated, work a.language Relates to the Dart language tour and removed st.triage.triage-team Triage team reviewing and categorizing the issue labels May 12, 2023
@parlough parlough added the fix.quality Needs improvement in copy quality label May 12, 2023
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label May 12, 2023
@atsansone atsansone added the from.team Reported by Dash docs team member label Aug 8, 2023
@parlough
Copy link
Member

parlough commented Aug 24, 2023

Some more specific feedback on the page from @feinstein:

I think we should expand the mixin docs, there are more details to them that are not in the tutorial.

For example, a mixin can have abstract functions, that should be declared into a class that uses the mixin, so on this sense a mixin can have abstract methods, or getters, etc, even though its not an abstract class mixin. I discovered this by exploring mixin, so I wonder what else I can do with them that I just didn't find out for myself.

Also we should be more emphatic about the mixin limitations, we only show them in the class, mixin, or mixin class? section for a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.language Relates to the Dart language tour e2-days Can complete in < 5 days of normal, not dedicated, work fix.quality Needs improvement in copy quality from.team Reported by Dash docs team member p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants