Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New diagnostic docs #5396

Closed
bwilkerson opened this issue Dec 7, 2023 · 2 comments
Closed

New diagnostic docs #5396

bwilkerson opened this issue Dec 7, 2023 · 2 comments
Assignees
@parlough
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. t.cli-tools Relates to the dart command line tools t.diagnostics Relates to diagnostics, analysis, or linting of code

Comments

@bwilkerson
Copy link
Member

I believe that all of the documentation for the diagnostics associated with extension types has now been committed, and is ready to be published.

I don't know when we want to publish these because I don't know when the feature will be enabled. As far as I know there's no rush.
@parlough parlough self-assigned this Dec 7, 2023
@parlough
Copy link
Member

parlough commented Dec 7, 2023 •
edited
Loading

Thanks for the heads up and for the great diagnostic messages! I was waiting for your recent CL to land, but I think these are good to update now since extension types are enabled by default on the newest 3.3 beta.

Opened #5397.

@parlough parlough added p1-high Major but not urgent concern: Resolve in months. Update each month. t.cli-tools Relates to the dart command line tools e0-minutes Can complete in < 60 minutes of normal, not dedicated, work t.diagnostics Relates to diagnostics, analysis, or linting of code labels Dec 7, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 7, 2023
@parlough
[analyzer] Mark new asset and extension type diagnostic docs as publi…
13fdaa0 
…shed

Closes dart-lang/site-www#5396

Bug: dart-lang/site-www#5396
Change-Id: Ic4ebe03fd7195a241608cffebfd91b11125c7fa2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Marya Belanger <mbelanger@google.com>
Reviewed-by: Marya Belanger <mbelanger@google.com>
@parlough
Copy link
Member

parlough commented Dec 7, 2023

Fixed by dart-lang/sdk@13fdaa0

@parlough parlough closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work p1-high Major but not urgent concern: Resolve in months. Update each month. t.cli-tools Relates to the dart command line tools t.diagnostics Relates to diagnostics, analysis, or linting of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwilkerson @parlough