Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize cmdline example migrations and updates #3276

Merged
merged 2 commits into from Jun 2, 2021
Merged

Finalize cmdline example migrations and updates #3276

merged 2 commits into from Jun 2, 2021

Conversation

parlough
Copy link
Member

No description provided.

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label May 25, 2021
kwalrath
kwalrath approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm curious about the test. Also... should this PR update the try-dart section to use single quotes for the Hello World example?

examples/misc/test/samples_test.dart Outdated Show resolved Hide resolved
@parlough parlough force-pushed the misc/finalize-cmdline-migration branch from 96baba6 to dbdccb3 Compare June 1, 2021 23:58
@parlough
Copy link
Member Author

parlough commented Jun 1, 2021

Good point on fixing the try-dart section here, thanks! Luckily the compile resulted in minimal changes.

@parlough parlough merged commit f0227f9 into dart-lang:master Jun 2, 2021
@kwalrath kwalrath mentioned this pull request Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalrath kwalrath kwalrath approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parlough @kwalrath