Updating the banner #4030
Merged
Updating the banner #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
approved these changes
May 9, 2022
|
Marking as draft to prevent accidental submission |
|
Visit the preview URL for this PR (updated for commit 6012a79): https://dart-dev--pr4030-banner-2xoimidg.web.app (expires Wed, 18 May 2022 15:42:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
mit-mit
reviewed
May 9, 2022
src/_includes/banner.html
Outdated
| @@ -1,7 +1,7 @@ | |||
| {% comment %}Drop the div .alert classes to revert to the default banner styling.{% endcomment -%} | |||
| <div class="banner"> | |||
| <p class="banner__text"> | |||
| Join Dart and Flutter at Google I/O 2022 live from Shoreline Amphitheatre and online May 11-12. <a href="https://io.google/2022/?utm_source=dart&utm_medium=embedded_marketing&utm_campaign=hpp_svd&utm_content=">Register now</a><br> | |||
| <a href="https://io.google/2022/?utm_source=dart&utm_medium=embedded_marketing&utm_campaign=hpp_svd&utm_content=">Google I/O is happening now. Join us.</a><br> | |||
There was a problem hiding this comment.
Should we consider deep-linking to https://io.google/2022/products/flutter/ ?
There was a problem hiding this comment.
Maybe for day 2? If we're publishing this at 10 AM (PT) that's when the main keynotes start which wouldn't be visible from the Flutter page.
|
Hmmm. I got this link from Kelvin. Can you check with him?
…On Mon, May 9, 2022 at 10:32 AM Michael Thomsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/_includes/banner.html
<#4030 (comment)>:
> @@ -1,7 +1,7 @@
{% comment %}Drop the div .alert classes to revert to the default banner styling.{% endcomment -%}
<div class="banner">
<p class="banner__text">
- Join Dart and Flutter at Google I/O 2022 live from Shoreline Amphitheatre and online May 11-12. <a href="https://io.google/2022/?utm_source=dart&utm_medium=embedded_marketing&utm_campaign=hpp_svd&utm_content=">Register now</a><br>
+ <a href="https://io.google/2022/?utm_source=dart&utm_medium=embedded_marketing&utm_campaign=hpp_svd&utm_content=">Google I/O is happening now. Join us.</a><br>
Should we consider deep-linking to
https://io.google/2022/products/flutter/ ?
—
Reply to this email directly, view it on GitHub
<#4030 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS4PKOXWPZQFR5IYKLKUMTVJFDZTANCNFSM5VO6ASKQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
parlough
reviewed
May 9, 2022
parlough
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't publish until Wednesday at 10am.