Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4144 issue: Update who-uses-dart page #4577

Closed
wants to merge 5 commits into from

Conversation

MikiPAUL
Copy link

@MikiPAUL MikiPAUL commented Feb 6, 2023

Hey @MaryaBelanger , I have made the changes as per the assigned issue. Please review the changes.

@google-cla
Copy link

google-cla bot commented Feb 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MaryaBelanger
Copy link
Contributor

Thanks @MikiPAUL! I'm going to pull this PR locally and work on it a little too, so let me know if you are planning to edit it further so I can wait and avoid merge conflicts.

Otherwise, I'll push my additions in the upcoming week or so, and we can go over it together! Looking forward to iterating with you, and thanks again for authoring this contribution ❤️

@MikiPAUL
Copy link
Author

MikiPAUL commented Feb 7, 2023

Hey @MaryaBelanger, Thanks for taking the time to review my contribution and make changes to it. I appreciate your collaboration and look forward to reviewing the changes together. I don't have any edit plan and you can start work on it. Let me know if there's anything else I can do to help.

src/community/who-uses-dart.md Outdated Show resolved Hide resolved
src/community/who-uses-dart.md Outdated Show resolved Hide resolved
MikiPAUL and others added 2 commits February 8, 2023 09:06
workiva typo fix

Co-authored-by: John Ryan <ryjohn@google.com>
workiva typo fix

Co-authored-by: John Ryan <ryjohn@google.com>
@MikiPAUL
Copy link
Author

MikiPAUL commented Feb 8, 2023

Hi @MaryaBelanger, I have made some updates to my pull request. I have fixed the typo. Please take a look at the pull request and I'm new to open source please let me know if you have done anything wrong.

@atsansone atsansone added the review.copy Awaiting Copy Review label Feb 13, 2023
@MaryaBelanger
Copy link
Contributor

@MikiPAUL I had to make some changes to adhere to our formatting and style guidelines, and I needed to create a new PR to do so. I need to close this one now, but I have added you as an author on the new PR, so you'll get authorship credit when it merges! Thanks for getting this started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.copy Awaiting Copy Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants