New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Update "Fixing type promotion failures" for private final field promo #5246
Conversation
Visit the preview URL for this PR (updated for commit f480d9d): https://dart-dev--pr5246-non-promotion-ag7gz8ua.web.app (expires Wed, 22 Nov 2023 18:02:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solutions for the conflict failures: I'm not sure if just renaming them is applicable when the two conflicting entities are related. Does the regular perscriptive advice apply to these three too? (i.e. create a local variable, use a null check, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great Marya! I think a couple things need some additional work, but nothing major. Let me know if any of my comments aren't clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done a full proper review of this yet (sorry), but quickly reading through it, it looks amazing and will be a great resource for those trying to better understand type promotion failures.
I did make sure to test the links though and they all work as expected.
A few minor adjustments before landing though:
Thank you Parker! |
… promo (dart-lang#5246) This is the work to add all the new field promotion failure anchors to the site. These are linked from context messages. --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>
This is the work to add all the new field promotion failure anchors to the site. These are linked from context messages.