Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Update "Fixing type promotion failures" for private final field promo #5246

Merged
merged 19 commits into from Nov 15, 2023

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Oct 12, 2023

This is the work to add all the new field promotion failure anchors to the site. These are linked from context messages.

@atsansone atsansone added the st.WIP Issue in progress label Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Visit the preview URL for this PR (updated for commit f480d9d):

https://dart-dev--pr5246-non-promotion-ag7gz8ua.web.app

(expires Wed, 22 Nov 2023 18:02:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@MaryaBelanger MaryaBelanger marked this pull request as ready for review November 7, 2023 00:56
@MaryaBelanger MaryaBelanger changed the title [Do not review] [3.2] Field promo draft [3.2] Update "Fixing type promotion failures" for private final field promo Nov 7, 2023
Copy link
Contributor Author

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solutions for the conflict failures: I'm not sure if just renaming them is applicable when the two conflicting entities are related. Does the regular perscriptive advice apply to these three too? (i.e. create a local variable, use a null check, etc)

firebase.json Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
@MaryaBelanger MaryaBelanger added review.tech Awaiting Technical Review and removed st.WIP Issue in progress labels Nov 7, 2023
Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great Marya! I think a couple things need some additional work, but nothing major. Let me know if any of my comments aren't clear.

src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a full proper review of this yet (sorry), but quickly reading through it, it looks amazing and will be a great resource for those trying to better understand type promotion failures.

I did make sure to test the links though and they all work as expected.

A few minor adjustments before landing though:

src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
firebase.json Outdated Show resolved Hide resolved
src/tools/non-promotion-reasons.md Outdated Show resolved Hide resolved
@parlough parlough removed the review.tech Awaiting Technical Review label Nov 15, 2023
@parlough parlough removed their assignment Nov 15, 2023
@MaryaBelanger
Copy link
Contributor Author

Thank you Parker!

@parlough parlough merged commit c7e458c into main Nov 15, 2023
9 checks passed
@parlough parlough deleted the non-promotion branch November 15, 2023 18:18
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
… promo (dart-lang#5246)

This is the work to add all the new field promotion failure anchors to
the site. These are linked from context messages.

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants