Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Futures tutorial #538

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Tests for Futures tutorial #538

merged 2 commits into from
Jan 31, 2018

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 30, 2018

@chalin chalin added a.tut.tutorial Relates to the Tutorial section of dart.dev test.general Relates to unit, integration, perf testing labels Jan 30, 2018
@chalin chalin requested a review from kwalrath January 30, 2018 12:01
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 30, 2018
@chalin chalin force-pushed the chalin-tut-async-prog-futures-1219 branch from 91b299c to bb91cab Compare January 30, 2018 12:35
@chalin chalin mentioned this pull request Jan 30, 2018
Closed
20 tasks
kwalrath
kwalrath approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kwalrath kwalrath merged commit 606a712 into dart-lang:master Jan 31, 2018
@chalin chalin deleted the chalin-tut-async-prog-futures-1219 branch January 31, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalrath kwalrath kwalrath approved these changes

Assignees
No one assigned
Labels
a.tut.tutorial Relates to the Tutorial section of dart.dev cla: yes Contributor has signed the Contributor License Agreement test.general Relates to unit, integration, perf testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalin @kwalrath @googlebot