Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from include to render where possible #5770

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented May 4, 2024

Contributes to #5768

Some includes rely on inheriting the parent still, which render purposefully doesn't support. They will need further updates before being able to migrate. Some rely on global data (such as site. variables), which 11ty doesn't yet expose to render, but likely will in the future. For now, those can keep using include.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented May 4, 2024

Visit the preview URL for this PR (updated for commit d2af822):

https://dart-dev--pr5770-misc-include-to-render-xvoqfizl.web.app

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why are only some changed to render? Could you explain this in the summary for this PR ahead of merging it?

@atsansone atsansone added the st.RFM.% Ready to Merge but has suggestions label May 6, 2024
@parlough parlough removed the st.RFM.% Ready to Merge but has suggestions label May 6, 2024
@parlough parlough merged commit c5ca81e into main May 6, 2024
10 checks passed
@parlough parlough deleted the misc/include-to-render branch May 24, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants