Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code excerpt checking for Dart 2 page #621

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Code excerpt checking for Dart 2 page #621

merged 1 commit into from
Mar 1, 2018

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 1, 2018

Contributes to #407

You might want to review by ignoring whitespace.

Staged https://dartlang-org-staging-0.firebaseapp.com/dart-2

@chalin chalin added SoundDart fix.examples Adds or changes example labels Mar 1, 2018
@chalin chalin requested a review from kwalrath March 1, 2018 17:24
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Mar 1, 2018
kwalrath
kwalrath approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sometime we should document how to add a tested excerpt (or test an existing excerpt).

@kwalrath kwalrath mentioned this pull request Mar 1, 2018
Closed
@chalin chalin merged commit 24fd81c into master Mar 1, 2018
@chalin chalin deleted the chalin-dart-2-tests-0301 branch March 1, 2018 22:44
@chalin chalin mentioned this pull request Mar 1, 2018
Closed
20 tasks
@atsansone atsansone added dev.null-safety Relates to transforming or migrating Dart code to sound null safety and removed SoundDart labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalrath kwalrath kwalrath approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement dev.null-safety Relates to transforming or migrating Dart code to sound null safety fix.examples Adds or changes example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chalin @kwalrath @atsansone @googlebot