Examples: add trivial Library and SharedPart builder examples #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress towards #322
kevmoo
force-pushed
the
i322_add_example
branch
from
b11acd7
to
db213a4
Compare
natebosch
approved these changes
Dec 21, 2018
| builder_factories: ["metadataLibraryBuilder"] | ||
| # The mapping from the source extension to the generated file extension | ||
| build_extensions: {".dart": [".info.dart"]} | ||
| # Will automatically run on any package that depends on it |
There was a problem hiding this comment.
[nit] Just as a note, this will only run on the root package if it depends on it because of the build_to: source. I'm not sure if that's worth calling out here or not.
There was a problem hiding this comment.
I thought that was implied. No?
There was a problem hiding this comment.
🤷♂️
I guess it's implied, but as I read this I was thrown off by the "any package" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #322