Fixes async gap handling.

[ghost]

This fixes an issue where an async gap at the end of a stack trace would not get parsed correctly due to the trailing newline being trim()'d.

A couple of tests were added to cover this case.

[natebosch]

Can you add a CHANGELOG entry?

[ghost]

RE:CHANGELOG: I assume I'm supposed to bump the version and update the pubspec too, right?

[natebosch]

I assume I'm supposed to bump the version and update the pubspec too, right?

In this case no, the existing version was OK. Anytime there is a trailing -dev on a version it should mean we are in between publishing, and can keep using the same version. When we get ready to publish we drop the -dev.

https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change

For future PRs it would also help to avoid a force push. We do a squash and merge once the PR is ready so we don't need to clean up into a single commit and force push ahead of time.

https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#handling-pull-requests

[mkustermann]

@natebosch We are a little pressed on time. Could you help us get this change published on pub and pulled into flutter/flutter? (we can do the latter)

[natebosch]

I opened #85

Once that is approved I'll publish and update here.

[natebosch]

This is published as 1.10.0-nullsafety.3

[ghost]

Thanks, Nate.

I see 1.10.0-nullsafety.3 on pub, but I noticed it has an odd [UNIDENTIFIED] tag on it, and the log points to this being an SDK version issue.

In the commit message you mentioned bumping the SDK version, but would it be possible to only bump the patch version so we can stay within currently stable SDK versions?

The reason I'm asking is that flutter update-packages --force-upgrade doesn't seem to pick up 1.10.0-nullsafety.3, and I suspect it's to do with the SDK version.

[natebosch]

You are trying to update the version pinned in the Flutter SDK? I would not have expected the SDK version to be a problem since they should be on 2.11.0-dev SDKs by now...

In any case I tested this on earlier SDKs and can't find an incompatibility so I'll drop the min back down.
#86