Skip to content

Commit

Permalink
Drop a TODO about running browser after compile (#2094)
Browse files Browse the repository at this point in the history
Starting the browser and running the first suite shouldn't be delayed by
compilation of all other suites. We may want to increase parallelization
of compiles at some point. I do not expect to make the change suggested
in the TODO.
  • Loading branch information
natebosch committed Sep 20, 2023
1 parent d8e9d87 commit 8191a35
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkgs/test/lib/src/runner/browser/platform.dart
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ class BrowserPlatform extends PlatformPlugin

if (_closed) return null;

// TODO(nweiz): Don't start the browser until all the suites are compiled.
var browserManager = await _browserManagerFor(browser);
if (_closed || browserManager == null) return null;

Expand Down

0 comments on commit 8191a35

Please sign in to comment.