Skip to content

Commit

Permalink
Fix dart run test -p chrome -c dart2wasm (#2233)
Browse files Browse the repository at this point in the history
* Fix `dart run test -p chrome -c dart2wasm`

package:test should not depend and use Dart SDK internal files, flags or
other internal things for invoking compilers.

Instead it should use the public `dart compile wasm` command.

Closes #2210

* fix testing to do last supported and dev
  • Loading branch information
mkustermann committed Jun 1, 2024
1 parent 2464ad5 commit b1b2c02
Show file tree
Hide file tree
Showing 5 changed files with 158 additions and 108 deletions.
237 changes: 145 additions & 92 deletions .github/workflows/dart.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion integration_tests/wasm/mono_pkg.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# See https://pub.dev/packages/mono_repo

sdk:
- main
- pubspec
- dev

stages:
- analyze_and_format:
Expand Down
Loading

0 comments on commit b1b2c02

Please sign in to comment.