Should throwsA mark tests pending when the value is a Future?
#1670
Comments
This test should be failing but the error is lost because `throwsA` does not force the test to wait until the condition is checked. dart-lang/test#1670 Fix the pattern to use `await expectLater` instead of `await expect` so the failure will show up. Skip the test for now.
|
Seems like we should imo, yes. I always thought it worked that way... |
|
hmm, I may be wrong about the root cause of that test not failing... I think the intention is this async work should be captured by test/pkgs/test_api/lib/src/expect/expect.dart Line 106 in e0be5ec I'm not sure why this failure is slipping through |
|
Ah, this bug is related to our use of zones in the build system. The root cause is that we're running test expectations in a nested zone which has it's own uncaught error handler. This test failure is getting ignored due to dart-lang/build#2599 I can't find the conversation now, but I think at one point we had discussed making |
|
Closing in favor of #1671 |
This test should be failing but the error is lost because of the way the async failure interacts with the `runBuilder` error handling zone. dart-lang/test#1670 Use `await expectLater` instead of `await expect` to ensure the error is not lost. Change the setup for the test to include two imports instead of 1 import and a local class definition. Move the usage to an annotation so that it is easy to find from the library using it.
It's possible to lose test failures if you use
throwsAagainst aFuturewhich does not complete until after all other tests are done.If we see a
Futurethat we expect to throw, should we mark the test pending until it completes?The text was updated successfully, but these errors were encountered: