Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialization of timeout in suite metadata fails in dart2wasm #2006

Closed
eyebrowsoffire opened this issue May 4, 2023 · 0 comments · Fixed by #2007
Closed

Deserialization of timeout in suite metadata fails in dart2wasm #2006

eyebrowsoffire opened this issue May 4, 2023 · 0 comments · Fixed by #2007
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@eyebrowsoffire
Copy link
Contributor

The following line:

test/pkgs/test_api/lib/src/backend/metadata.dart

Line 285 in 9484592

return Timeout(Duration(microseconds: serialized['duration'] as int));

Fails on dart2wasm, because the underlying type is double and cannot be simply cast to an int.
@eyebrowsoffire eyebrowsoffire added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label May 4, 2023
@eyebrowsoffire eyebrowsoffire mentioned this issue May 4, 2023
Merged
jakemac53 pushed a commit that referenced this issue May 5, 2023
@eyebrowsoffire
Don't do direct casts to int to prevent dart2wasm breakages. (#2007)
1d65501 
This fixes #2006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't do direct casts to int to prevent dart2wasm breakages. eyebrowsoffire/dart_test
1 participant
@eyebrowsoffire