Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --pause-on-error in Chrome and PhantomJS #299

Open
nex3 opened this issue Jul 22, 2015 · 2 comments
Open

Support --pause-on-error in Chrome and PhantomJS #299

nex3 opened this issue Jul 22, 2015 · 2 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@nex3
Copy link
Member

nex3 commented Jul 22, 2015

This is a very useful flag for debugging. With #294 and #296 it isn't strictly necessary, since the user can just set it manually via the dev tools, but it's much easier to set it via the command-line.

This will require starting and connecting to the Chrome dev tools and sending Debugger.setPauseOnExceptions before we begin loading or running tests. I'm reasonably sure that PhantomJS uses a similar protocol, since it's WebKit based and its remote debugger is Chrome-compatible, but we'll have to make sure.

It's also possible that this could work with IE using the IE Diagnostics Adapter.

@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Jul 22, 2015
@nex3 nex3 added this to the 1.0.0 milestone Jul 22, 2015
@grouma grouma self-assigned this Jun 6, 2017
@grouma grouma added the status-blocked Blocked from making progress by another (referenced) issue label Jun 8, 2017
@grouma
Copy link
Member

grouma commented Jun 8, 2017

Ideally we should make use of google/webkit_inspection_protocol.dart

However, allowing the user to interact with the chrome dev tools through the UI and WIP at the same time is blocked by https://bugs.chromium.org/p/chromium/issues/detail?id=129539.

@grouma grouma removed the status-blocked Blocked from making progress by another (referenced) issue label Jun 15, 2018
@grouma
Copy link
Member

grouma commented Jun 15, 2018

Looks like the blocking bug was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants