Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from comment-based generics syntax #667

Closed
srawlins opened this issue Jul 26, 2017 · 3 comments
Closed

Upgrade from comment-based generics syntax #667

srawlins opened this issue Jul 26, 2017 · 3 comments
Assignees
@grouma

Comments

@srawlins
Copy link
Member

The comment-based generics syntax will be removed from the Dart SDK tools (like DDC, analyzer) "soon." dart-lang/sdk#28796

Such syntax (like in expectAsync0) needs to be updated.
@keertip
Copy link
Contributor

keertip commented Aug 16, 2017

@grouma, could you get these fixes in too with the next version into google3?

@grouma
Copy link
Member

grouma commented Aug 16, 2017

@keertip is there a timeline for this? I'm pretty heads down with the archive stuff so likely won't be able to get to this in the near future.

natebosch added a commit that referenced this issue Aug 22, 2017
@natebosch
Use non-comment generic method syntax
7d8e81f 
Fixes #667
@natebosch natebosch mentioned this issue Aug 22, 2017
Merged
natebosch added a commit that referenced this issue Aug 22, 2017
@natebosch
Use non-comment generic method syntax (#676)
bf6aaca 
Fixes #667
@keertip
Copy link
Contributor

keertip commented Aug 22, 2017

Thanks Nate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grouma grouma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @grouma @keertip