Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation of test_api top level libraries #1994

Merged
merged 4 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/test/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 1.24.2-dev
## 1.24.2

* Copy an existing nonce from a script on the test HTML page to the script
created by the test runner host javascript. This only impacts environments
Expand Down
6 changes: 3 additions & 3 deletions pkgs/test/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test
version: 1.24.2-dev
version: 1.24.2
description: >-
A full featured library for writing and running Dart tests across platforms.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test
Expand Down Expand Up @@ -32,8 +32,8 @@ dependencies:
webkit_inspection_protocol: ^1.0.0
yaml: ^3.0.0
# Use an exact version until the test_api and test_core package are stable.
test_api: 0.5.1
test_core: 0.5.1
test_api: 0.5.2
test_core: 0.5.2
# Use a tight version constraint to ensure that a constraint on matcher
# properly constrains all features it provides.
matcher: '>=0.12.15 <0.12.16'
Expand Down
5 changes: 5 additions & 0 deletions pkgs/test_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.5.2

* Remove deprecation for the `scaffolding.dart` and `backend.dart` libraries.
* Export `registerException` from the `scaffolding.dart` library.

## 0.5.1

* Handle a missing `'compiler'` value when running a test compiled against a
Expand Down
4 changes: 0 additions & 4 deletions pkgs/test_api/lib/backend.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

@Deprecated('package:test_api is not intended for general use. '
'Please use package:test.')
library test_api.backend;

export 'src/backend/compiler.dart' show Compiler;
export 'src/backend/metadata.dart' show Metadata;
export 'src/backend/platform_selector.dart' show PlatformSelector;
Expand Down
4 changes: 1 addition & 3 deletions pkgs/test_api/lib/scaffolding.dart
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
/// {@canonicalFor tags.Tags}
/// {@canonicalFor test_on.TestOn}
/// {@canonicalFor timeout.Timeout}
@Deprecated('package:test_api is not intended for general use. '
'Please use package:test.')
library test_api.scaffolding;

export 'src/backend/configuration/on_platform.dart' show OnPlatform;
Expand All @@ -22,4 +20,4 @@ export 'src/scaffolding/spawn_hybrid.dart' show spawnHybridUri, spawnHybridCode;
export 'src/scaffolding/test_structure.dart'
show group, test, setUp, setUpAll, tearDown, tearDownAll, addTearDown;
export 'src/scaffolding/utils.dart'
show pumpEventQueue, printOnFailure, markTestSkipped;
show markTestSkipped, printOnFailure, pumpEventQueue, registerException;
2 changes: 0 additions & 2 deletions pkgs/test_api/lib/test_api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,3 @@ export 'package:matcher/expect.dart';

export 'hooks.dart' show TestFailure;
export 'scaffolding.dart';
// Not yet deprecated, but not exposed through focused libraries.
export 'src/scaffolding/utils.dart' show registerException;
2 changes: 1 addition & 1 deletion pkgs/test_api/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_api
version: 0.5.1
version: 0.5.2
description: >-
The user facing API for structuring Dart tests and checking expectations.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test_api
Expand Down
4 changes: 4 additions & 0 deletions pkgs/test_core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.2

natebosch marked this conversation as resolved.
Show resolved Hide resolved
* Use the version `0.5.2` of `packge:test_api`.

## 0.5.1

* Start adding experimental support for native_assets.yaml, when
Expand Down
4 changes: 2 additions & 2 deletions pkgs/test_core/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_core
version: 0.5.1
version: 0.5.2
description: A basic library for writing tests and running them on the VM.
repository: https://github.com/dart-lang/test/tree/master/pkgs/test_core

Expand Down Expand Up @@ -30,7 +30,7 @@ dependencies:
# matcher is tightly constrained by test_api
matcher: ^0.12.11
# Use an exact version until the test_api package is stable.
test_api: 0.5.1
test_api: 0.5.2

dev_dependencies:
lints: '>=1.0.0 <3.0.0'