Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): add env overrides for safari and ff #2042

Merged
merged 6 commits into from
Jun 28, 2023
Merged

feat(runner): add env overrides for safari and ff #2042

merged 6 commits into from
Jun 28, 2023

Conversation

Zekfad
Copy link
Contributor

@Zekfad Zekfad commented Jun 23, 2023

adds SAFARI_EXECUTABLE and FIREFOX_EXECUTABLE
this allows you to use FF Developer Edition and Safari Technology Preview.
Also there are already MS_EDGE_EXECUTABLE that were missing test.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@Zekfad
Copy link
Contributor Author

Zekfad commented Jun 23, 2023

For anyone with problems running FF: here's the catch:
For some reason you must use either --headless flag, or set MOZ_AUTOMATION env variable to true.
Ref: https://github.com/mozilla/gecko-dev/blob/6755226f52a02eac8b18f25a6f522e9c0814b628/browser/app/winlauncher/LauncherProcessWin.cpp#L165-L167

Update:
Found that you must use --wait-for-browser to make launcher process wait until browser exits.

@natebosch
Copy link
Member

Can you add a CHANGELOG entry?

@Zekfad
Copy link
Contributor Author

Zekfad commented Jun 28, 2023

@natebosch, added changelog entry to current 1.24.4-wip.

@jakemac53 jakemac53 merged commit 2904779 into dart-lang:master Jun 28, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants