Add stream matchers. #532
Add stream matchers. #532
Conversation
| /// If any matchers match the stream, no errors from other matchers are thrown. | ||
| /// If no matchers match and multiple matchers threw errors, the first error is | ||
| /// re-thrown. | ||
| StreamMatcher emitsAnyOf(Iterable matchers) { |
There was a problem hiding this comment.
Error if the iterable is empty?
| try { | ||
| result = await streamMatchers[i].matchQueue(copy); | ||
| } catch (error, stackTrace) { | ||
| if (error != null) { |
There was a problem hiding this comment.
error should never be null. Is this case needed?
There was a problem hiding this comment.
Oops, this was supposed to check firstError.
| } | ||
|
|
||
| /// Returns a [StreamMatcher] that matches any number of | ||
| /// events followed by events that match [matcher]. |
There was a problem hiding this comment.
Nit: The wrapping here looks arbitrary.
| while (await queue.hasNext) { | ||
| if (await tryHere()) return null; | ||
| await queue.next; | ||
| } |
There was a problem hiding this comment.
This function is quadratic, right? Or I guess, more specifically O(mn) where m is the stream length and n is the matcher's length.
That's OK, but it would probably be good to mention it since it can get slow with long streams and matchers.
Or you could adapt Boyer-Moore to this. 😛
There was a problem hiding this comment.
The quadradic behavior is only relevant when the matcher can match long strings of events and when in practice it matches many long prefixes without satisfying the entire matcher. I don't think that's likely enough to come up in practice to warrant documenting.
|
Late to the party, but yay! Nice work @nex3! |
No description provided.