Add the ability to define and override test platforms #706

nex3 · 2017-10-19T19:15:51Z

See #99
Closes #391

This will make it easier to define custom test platforms (both via #391 and #99) in the future. Because those platforms will be loaded based on the configuration, requiring knowledge of them to parse the user's platform arguments would produce an unresolvable circular dependency.

We want users to be able to dynamically define new platforms, which means we need infrastructure in place for piping those platforms to places that previously assumed TestPlatform.all was a full list of available platforms. PlatformSelector is the trickiest example, since it's parsed in a number of different places and needs to provide useful feedback to users when they use an undefined platform. This splits parsing and platform validation into two separate steps. Validation will be done immediately after parsing when the selectors come from top-level annotations or parameters passed to test() or group(), but selectors defined in configuration files are now parsed only after all configuration is parsed. This will allow new platforms to be defined *and* referenced in configuration files. See #99 See #391

This ensures that the remote listener has access to any platforms that are dynamically loaded in the test runner, so they can be used in platform selectors. See #99 See #391

Now that the Loader is the canonical place for determining which TestPlatforms are valid, we no longer need a separate mechanism for registering platforms. Adding a plugin to the loader is sufficient. See #391

This makes it easier to add platforms that extend existing platforms without running into serialization headaches. It also cleans up the Declarer API and means we're sending less redundant data between isolates.

This doesn't really do anything yet, since no platforms currently support customization. See #391

See #391

Add a define_platforms configuration field

See #391

Add an override_platforms config field

See #391

nex3 and others added 15 commits October 3, 2017 13:48

Send test platforms to the remote listener (#694)

0a3f688

This ensures that the remote listener has access to any platforms that are dynamically loaded in the test runner, so they can be used in platform selectors. See #99 See #391

Remove registerTestPlatform() (#695)

44cfc06

Now that the Loader is the canonical place for determining which TestPlatforms are valid, we no longer need a separate mechanism for registering platforms. Adding a plugin to the loader is sufficient. See #391

Validate platform selectors against string sets (#696)

7154a85

This makes it easier to add platforms that extend existing platforms without running into serialization headaches. It also cleans up the Declarer API and means we're sending less redundant data between isolates.

Add a define_platforms configuration field

9aad31e

This doesn't really do anything yet, since no platforms currently support customization. See #391

Make browser platforms customizable

d65bbbb

See #391

Document define_platforms and browser settings

31d0a80

See #391

Merge pull request #697 from dart-lang/define-platforms

b1e8da7

Add a define_platforms configuration field

Forbid define_platforms in the global config file

465927c

Forbid define_platforms in the global config file (#701)

0f63fbc

Add an override_platforms config field

0d96eda

See #391

Merge pull request #702 from dart-lang/override-platforms

5670a12

Add an override_platforms config field

Support configuring the Node platform (#703)

40b596a

See #391

Add an arguments field to executable settings (#704)

1d3ae92

See #391

nex3 requested a review from grouma October 19, 2017 19:15

googlebot added the cla: yes label Oct 19, 2017

grouma approved these changes Oct 19, 2017

View reviewed changes

nex3 merged commit 47debed into master Oct 19, 2017

nex3 deleted the feature.flexible-test-platforms branch October 19, 2017 22:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to define and override test platforms #706

Add the ability to define and override test platforms #706

nex3 commented Oct 19, 2017

Add the ability to define and override test platforms #706

Add the ability to define and override test platforms #706

Conversation

nex3 commented Oct 19, 2017