Fix logic for first run to fix shouldShowMessage behavior

[eliasyishak]

This cleans up the logic so that we can separate the logic for okToSend and shouldShowMessage

This came up while migrating devtools to package:unified_analytics

Before this PR

final Analytics analytics = Analytics(...);

print(analytics.shouldShowMessage);  // <-- this would return true on first runs

// Invoke the command to let the package know the client has seen a message
analytics.clientShowedMessage();

print(analytics.shouldShowMessage);  // <-- this would still return true; bad

The above shows that invoking analytics.shouldShowMessage after confirming we have shown the message would not change what gets returned.

This was never caught when working with the flutter cli because when we run the check for shouldShowMessage, it only happened once. With devtools, because it is an app that would check shouldShowMessage every time a new window is created in Chrome, it would continue to show the consent message even if the user has already accepted in the first window in Chrome.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:unified_analytics	5.8.1	ready to publish	unified_analytics-v5.8.1
package:cli_config	0.1.2	already published at pub.dev
package:extension_discovery	2.0.1-wip	WIP (no publish necessary)
package:graphs	2.3.2-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[christopherfujino]

I think @kenzieschmoll should probably review this and decide if this is the right semantics.

[eliasyishak]

I think @kenzieschmoll should probably review this and decide if this is the right semantics.

sounds good, @kenzieschmoll let me know if you'd like to review this together

[eliasyishak]

These tests are the best example for this change

[kenzieschmoll]

hmm... does this mean if the user accepts analytics collection, and then does a bunch of interactions with our tools that we will not send any events for this session? It seems like we should start sending events as soon as the user accepts, even if it is the first run.

[eliasyishak]

This was actually a requirement from the PDD, even for users that have opted in, analytic events will only be collected on the second time it is run. It's also listed in the consent message that was approved

The {{ toolDescription }} uses Google Analytics to report usage and diagnostic
data along with package dependencies, and crash reporting to send basic crash
reports. This data is used to help improve the Dart platform, Flutter framework,
and related tools.

Telemetry is not sent on the very first run. To disable reporting of telemetry,
run this terminal command:

    {{ toolName }} --disable-analytics

If you opt out of telemetry, an opt-out event will be sent, and then no further
information will be sent. This data is collected in accordance with the Google
Privacy Policy (https://policies.google.com/privacy).